test: migrate math/base/special/factorial2f to ULP-based assertions - #14364
Draft
kgryte wants to merge 1 commit into
Draft
test: migrate math/base/special/factorial2f to ULP-based assertions#14364kgryte wants to merge 1 commit into
math/base/special/factorial2f to ULP-based assertions#14364kgryte wants to merge 1 commit into
Conversation
Ref: #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-bot
added
Math
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/factorial2ffrom relative tolerance assertions to ULP difference assertions, as described in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tolcomputation (previously2.4 * EPS * absf( expected[i] )) and the associatedt.ok( delta <= tol, ... )/ exact-equality branch with a singlet.strictEqual( isAlmostSameValue( v, expected[ i ], 3 ), true, 'returns expected value' )assertion.@stdlib/number/float32/base/assert/is-almost-same-value(the single-precision variant, asfactorial2foperates on single-precision values) and removes the now unused@stdlib/math/base/special/absfand@stdlib/constants/float32/epsrequires.The same change is applied to both
test/test.jsandtest/test.native.js.ULP bound:
3ULP, for the "the function evaluates the double factorial" test in bothtest/test.jsandtest/test.native.js. This is the measured minimum over the full fixture set (56 values,test/fixtures/python/data.json); the observed ULP difference distribution is{0: 32, 1: 20, 2: 2, 3: 2}, with the maximum occurring atx = 47. Lowering the bound to2causes 2 test cases to fail, so3is the tightest bound which passes. The suite was run twice at the final bound to confirm the result is deterministic.Only the two test files are changed; no source, documentation, or fixture files were touched.
Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
test/test.native.jsis skipped locally, as the native add-on was not built in this environment. The ULP bound intest/test.native.jsmirrors the bound measured for the JavaScript implementation, consistent with prior conversions in this family (e.g.,math/base/special/cphasef,math/base/special/gammaln).NOTEexplaining why approximate equality is used for these fixtures (SciPy computes the expected values via gamma function approximations rather than iterative single-precision computation) has been retained, as it remains applicable.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, running as an automated task. The ULP bound was determined empirically by measuring the ULP difference across the full fixture set and verifying that the next lower bound fails.
@stdlib-js/reviewers
Generated by Claude Code